FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 41 |
23 |
0 |
0 |
org.apache.river.reggie.proxy.ClassMapper$FieldComparator
org.apache.river.reggie.proxy.ConstrainableAdminProxy
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.reggie.proxy.ConstrainableAdminProxy doesn't override AdminProxy.equals(Object) |
STYLE |
EQ_DOESNT_OVERRIDE_EQUALS |
1 |
Medium |
org.apache.river.reggie.proxy.ConstrainableEventLease
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.reggie.proxy.ConstrainableEventLease doesn't override EventLease.equals(Object) |
STYLE |
EQ_DOESNT_OVERRIDE_EQUALS |
1 |
Medium |
org.apache.river.reggie.proxy.ConstrainableRegistrarProxy
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.reggie.proxy.ConstrainableRegistrarProxy doesn't override RegistrarProxy.equals(Object) |
STYLE |
EQ_DOESNT_OVERRIDE_EQUALS |
1 |
Medium |
org.apache.river.reggie.proxy.ConstrainableRegistration
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.reggie.proxy.ConstrainableRegistration doesn't override Registration.equals(Object) |
STYLE |
EQ_DOESNT_OVERRIDE_EQUALS |
1 |
Medium |
org.apache.river.reggie.proxy.ConstrainableServiceLease
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.reggie.proxy.ConstrainableServiceLease doesn't override ServiceLease.equals(Object) |
STYLE |
EQ_DOESNT_OVERRIDE_EQUALS |
1 |
Medium |
org.apache.river.reggie.proxy.EntryClass
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to numFields in org.apache.river.reggie.proxy.EntryClass.check(AtomicSerial$GetArg) |
STYLE |
DLS_DEAD_LOCAL_STORE |
108 |
Medium |
org.apache.river.reggie.proxy.EntryRep
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to codebase in org.apache.river.reggie.proxy.EntryRep.check(AtomicSerial$GetArg) |
STYLE |
DLS_DEAD_LOCAL_STORE |
99 |
Medium |
| Dead store to eclass in org.apache.river.reggie.proxy.EntryRep.check(AtomicSerial$GetArg) |
STYLE |
DLS_DEAD_LOCAL_STORE |
95 |
Medium |
| Dead store to fields in org.apache.river.reggie.proxy.EntryRep.check(AtomicSerial$GetArg) |
STYLE |
DLS_DEAD_LOCAL_STORE |
100 |
Medium |
| Redundant nullcheck of org.apache.river.reggie.proxy.EntryRep.fields, which is known to be non-null in new org.apache.river.reggie.proxy.EntryRep(Entry, boolean) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
159 |
Medium |
| Redundant nullcheck of org.apache.river.reggie.proxy.EntryRep.fields, which is known to be non-null in new org.apache.river.reggie.proxy.EntryRep(EntryRep, boolean) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
133 |
Medium |
org.apache.river.reggie.proxy.EventLease
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to eventID in org.apache.river.reggie.proxy.EventLease.check(AtomicSerial$GetArg) |
STYLE |
DLS_DEAD_LOCAL_STORE |
72 |
Medium |
org.apache.river.reggie.proxy.Item
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.reggie.proxy.Item.setAttributeSets(EntryRep[]) may expose internal representation by storing an externally mutable object into Item.attributeSets |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
310 |
Medium |
org.apache.river.reggie.proxy.ProxyVerifier
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return true for all non-null values in org.apache.river.reggie.proxy.ProxyVerifier.readObject(ObjectInputStream), since all net.jini.core.constraint.RemoteMethodControl are instances of net.jini.core.constraint.RemoteMethodControl |
STYLE |
BC_VACUOUS_INSTANCEOF |
146 |
Medium |
org.apache.river.reggie.proxy.RegistrarEvent
| Bug |
Category |
Details |
Line |
Priority |
| instanceof will always return true for all non-null values in org.apache.river.reggie.proxy.RegistrarEvent.check(AtomicSerial$GetArg), since all net.jini.core.lookup.ServiceID are instances of net.jini.core.lookup.ServiceID |
STYLE |
BC_VACUOUS_INSTANCEOF |
83 |
Medium |
org.apache.river.reggie.proxy.RegistrarLease
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to r in org.apache.river.reggie.proxy.RegistrarLease.check(AtomicSerial$GetArg) |
STYLE |
DLS_DEAD_LOCAL_STORE |
79 |
Medium |
org.apache.river.reggie.proxy.Registration
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from net.jini.core.constraint.RemoteMethodControl to org.apache.river.reggie.proxy.Registrar in org.apache.river.reggie.proxy.Registration.getInstance(Object, ServiceLease, MethodConstraints) |
STYLE |
BC_UNCONFIRMED_CAST |
132 |
Medium |
| Class org.apache.river.reggie.proxy.Registration defines non-transient non-serializable instance field server |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
org.apache.river.reggie.proxy.RenewResults
| Bug |
Category |
Details |
Line |
Priority |
| new org.apache.river.reggie.proxy.RenewResults(long[], Exception[]) may expose internal representation by storing an externally mutable object into RenewResults.durations |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
59 |
Medium |
| new org.apache.river.reggie.proxy.RenewResults(long[], Exception[]) may expose internal representation by storing an externally mutable object into RenewResults.exceptions |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
60 |
Medium |
org.apache.river.reggie.proxy.ServiceType
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.reggie.proxy.ServiceType.getInterfaces() may expose internal representation by returning ServiceType.interfaces |
MALICIOUS_CODE |
EI_EXPOSE_REP |
198 |
Medium |
| new org.apache.river.reggie.proxy.ServiceType(Class, ServiceType, ServiceType[]) may expose internal representation by storing an externally mutable object into ServiceType.interfaces |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
159 |
Medium |
