FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 36 |
25 |
0 |
0 |
org.apache.river.tool.envcheck.EnvCheck
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.tool.envcheck.EnvCheck.loadConfiguration() invokes System.exit(...), which shuts down the entire virtual machine |
BAD_PRACTICE |
DM_EXIT |
640 |
Medium |
| org.apache.river.tool.envcheck.EnvCheck.parseArgs(String[]) invokes System.exit(...), which shuts down the entire virtual machine |
BAD_PRACTICE |
DM_EXIT |
438 |
Medium |
| org.apache.river.tool.envcheck.EnvCheck.run(String[]) invokes System.exit(...), which shuts down the entire virtual machine |
BAD_PRACTICE |
DM_EXIT |
546 |
Medium |
| org.apache.river.tool.envcheck.EnvCheck.getArgs() may expose internal representation by returning EnvCheck.args |
MALICIOUS_CODE |
EI_EXPOSE_REP |
681 |
Medium |
| org.apache.river.tool.envcheck.EnvCheck.getDescriptors() may expose internal representation by returning EnvCheck.descriptors |
MALICIOUS_CODE |
EI_EXPOSE_REP |
504 |
Medium |
| org.apache.river.tool.envcheck.EnvCheck.launch(String, Properties, String[], String[]) may fail to close stream |
BAD_PRACTICE |
OS_OPEN_STREAM |
873 |
Medium |
org.apache.river.tool.envcheck.EnvCheck$Pipe
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.apache.river.tool.envcheck.EnvCheck$Pipe.run(): java.io.ByteArrayOutputStream.toString() |
I18N |
DM_DEFAULT_ENCODING |
1245 |
High |
| Found reliance on default encoding in org.apache.river.tool.envcheck.EnvCheck$Pipe.write(byte): java.io.ByteArrayOutputStream.toString() |
I18N |
DM_DEFAULT_ENCODING |
1284 |
High |
| Should org.apache.river.tool.envcheck.EnvCheck$Pipe be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
1181-1291 |
Medium |
org.apache.river.tool.envcheck.plugins.CheckActivationSystem
| Bug |
Category |
Details |
Line |
Priority |
| Write to static field org.apache.river.tool.envcheck.plugins.CheckActivationSystem.doCheck from instance method org.apache.river.tool.envcheck.plugins.CheckActivationSystem.isPluginOption(String) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
60 |
High |
org.apache.river.tool.envcheck.plugins.CheckCodebase$URLAccessor
| Bug |
Category |
Details |
Line |
Priority |
| Should org.apache.river.tool.envcheck.plugins.CheckCodebase$URLAccessor be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
351-367 |
Medium |
org.apache.river.tool.envcheck.plugins.CheckConfig$ConfigTask
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.tool.envcheck.plugins.CheckConfig$ConfigTask.run(String[]) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead |
PERFORMANCE |
DM_BOOLEAN_CTOR |
313 |
Medium |
org.apache.river.tool.envcheck.plugins.CheckJDK1_4$JDK1_4Task
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.tool.envcheck.plugins.CheckJDK1_4$JDK1_4Task.run(String[]) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead |
PERFORMANCE |
DM_BOOLEAN_CTOR |
119 |
Medium |
org.apache.river.tool.envcheck.plugins.CheckJSKPlatform
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.tool.envcheck.plugins.CheckJSKPlatform.checkItem(String, String) may fail to close stream |
BAD_PRACTICE |
OS_OPEN_STREAM |
157 |
Medium |
| org.apache.river.tool.envcheck.plugins.CheckJSKPlatform.checkItem(String, String) concatenates strings using + in a loop |
PERFORMANCE |
SBSC_USE_STRINGBUFFER_CONCATENATION |
177 |
Medium |
| Unread field: org.apache.river.tool.envcheck.plugins.CheckJSKPlatform.envCheck |
PERFORMANCE |
URF_UNREAD_FIELD |
59 |
Medium |
org.apache.river.tool.envcheck.plugins.CheckJSKPolicy
| Bug |
Category |
Details |
Line |
Priority |
| Unused field: org.apache.river.tool.envcheck.plugins.CheckJSKPolicy.codebase |
PERFORMANCE |
UUF_UNUSED_FIELD |
Not available |
Medium |
org.apache.river.tool.envcheck.plugins.CheckJSKPolicy$JSKPolicyTask
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.tool.envcheck.plugins.CheckJSKPolicy$JSKPolicyTask.run(String[]) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead |
PERFORMANCE |
DM_BOOLEAN_CTOR |
97 |
Medium |
org.apache.river.tool.envcheck.plugins.CheckJsseProps
| Bug |
Category |
Details |
Line |
Priority |
| Write to static field org.apache.river.tool.envcheck.plugins.CheckJsseProps.doChecks from instance method org.apache.river.tool.envcheck.plugins.CheckJsseProps.isPluginOption(String) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
92 |
High |
org.apache.river.tool.envcheck.plugins.CheckJsseProps$CheckProviderTask
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.tool.envcheck.plugins.CheckJsseProps$CheckProviderTask.run(String[]) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead |
PERFORMANCE |
DM_BOOLEAN_CTOR |
461 |
Medium |
org.apache.river.tool.envcheck.plugins.CheckPersistence$GetEntriesTask
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.tool.envcheck.plugins.CheckPersistence$GetEntriesTask.getEntries(Configuration) concatenates strings using + in a loop |
PERFORMANCE |
SBSC_USE_STRINGBUFFER_CONCATENATION |
227 |
Medium |
org.apache.river.tool.envcheck.plugins.CheckPolicy
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to policy in org.apache.river.tool.envcheck.plugins.CheckPolicy.loadPolicy() |
STYLE |
DLS_DEAD_LOCAL_STORE |
100 |
Medium |
| Found reliance on default encoding in org.apache.river.tool.envcheck.plugins.CheckPolicy.loadPolicy(): java.io.ByteArrayOutputStream.toString() |
I18N |
DM_DEFAULT_ENCODING |
102 |
High |
| Found reliance on default encoding in org.apache.river.tool.envcheck.plugins.CheckPolicy.loadPolicy(): new java.io.PrintStream(OutputStream) |
I18N |
DM_DEFAULT_ENCODING |
99 |
High |
org.apache.river.tool.envcheck.plugins.CheckPolicy$AllPermissionsTask
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.river.tool.envcheck.plugins.CheckPolicy$AllPermissionsTask.run(String[]) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead |
PERFORMANCE |
DM_BOOLEAN_CTOR |
212 |
Medium |
