FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
Files
| Class | Bugs |
|---|---|
| org.apache.river.tool.PreferredListGen | 8 |
| org.apache.river.tool.PreferredListGen$Graph | 4 |
| org.apache.river.tool.PreferredListGen$PrefData | 2 |
org.apache.river.tool.PreferredListGen
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.apache.river.tool.PreferredListGen.buildJarFile(String): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 1379 | High |
| Found reliance on default encoding in org.apache.river.tool.PreferredListGen.generatePreferredList(PrintWriter): new java.io.PrintWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 1284 | High |
| org.apache.river.tool.PreferredListGen.compute() creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block | MALICIOUS_CODE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 1154 | Medium |
| Inconsistent synchronization of org.apache.river.tool.PreferredListGen.targetJar; locked 66% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 1732 | Medium |
| org.apache.river.tool.PreferredListGen.buildJarFile(String) may fail to clean up java.io.InputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 1400 | Medium |
| org.apache.river.tool.PreferredListGen.buildJarFile(String) may fail to clean up java.io.OutputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 1401 | Medium |
| org.apache.river.tool.PreferredListGen.createGraph(File) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 857 | Medium |
| org.apache.river.tool.PreferredListGen.noPreferredList(File) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 784 | Medium |
| org.apache.river.tool.PreferredListGen.populateGraph(PreferredListGen$Graph, File) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 799 | Medium |
org.apache.river.tool.PreferredListGen$Graph
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in org.apache.river.tool.PreferredListGen$Graph.impliedChildPref(), since all Boolean are instances of Boolean | STYLE | BC_VACUOUS_INSTANCEOF | 1772 | Medium |
| Inconsistent synchronization of org.apache.river.tool.PreferredListGen$Graph.preferred; locked 88% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 2166 | Medium |
| Inconsistent synchronization of org.apache.river.tool.PreferredListGen$Graph.type; locked 78% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 2241 | Medium |
org.apache.river.tool.PreferredListGen$PrefData
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.river.tool.PreferredListGen$PrefData defines compareTo(Object) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 1465-1466 | Medium |
| Should org.apache.river.tool.PreferredListGen$PrefData be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1455-1475 | Medium |